I took some time to look back at my MVC Post-Redirect-Get sample and see where it could be improved as well as update it to use the MVC Preview 3 bits. What I found, is again, the core concepts didn't change that much. However, there are some new enhancements that Preview 3 gave us that makes our life a little bit easier. I'll save the full implementation for you to download and checkout yourself, but I do want to highlight some of these enhancements that made the source easier to use.
1. NameValueCollectionExtensions.CopyTo - this made it very nice for me to take all of the posted form data and copy it into the TempData so that upon a redirect, I could extract it out and put it in ViewData.
1: if (!BaseValidator.Validate(HttpContext.Request, validators)) {
2: NameValueCollectionExtensions.CopyTo(Request.Form, TempData);
3: TempData["ErrorMessage"] = BuildErrorMessage(validators);
4: return RedirectToAction("Create");
5: }
2. I added an extension method for IDictionary to copy between a source and destination, primarily for copying my TempData to ViewData. This way there is no need to do a manual copy of TempData objects all over the place, and is more resilient to changes and additions within your views and controller actions. I'm hoping this makes it into the MVC stack at some point so we all don't have to write this code ourselves.
1: public static void CopyTo(this IDictionary<string, object> source,
2: IDictionary<string, object> destination)
3: {
4: foreach (KeyValuePair<string, object> pair in source)
5: {
6: if (!destination.ContainsKey(pair.Key))
7: destination.Add(pair.Key, pair.Value);
8: }
9: }
The above code allows us to simply call the following line of code
1: TempData.CopyTo(ViewData);
3. What you'll notice, is that now all of my data is within ViewData, I can start to utilize the built-in functionality added in Preview 3 where the form controls will attempt to extract an initial value from ViewData. This mechanism really brings back the concept of ViewState, except that there is really no overhead to do this! Here's how my form now looks
1: <%@ Import Namespace="PRG.Controllers" %>
2: <asp:Content ID="Content1" ContentPlaceHolderID="MainContent" runat="server">
3: <% using (Html.Form<ProductsController>(c => c.Submit())) { %>
4: <h3>Create a New Product</h3>
5: Name: <%= Html.TextBox("Name") %><br />
6: Price: <%= Html.TextBox("Price") %><br />
7: Quantity: <%= Html.TextBox("Quantity") %><br />
8: <% if (ViewData["ErrorMessage"] != null) { %>
9: <br /><span style="color:red"><%= ViewData["ErrorMessage"] %></span><br />
10: <% } %>
11: <br />
12: <%= Html.SubmitButton() %>
13: <% } %>
14: </asp:Content>
4. While this next item isn't specifically related to Preview 3, it is a change from my last sample. Previously, I was doing all of my manual validations inline on the server, and it wasn't pretty. As you've probably been reading, I've been making some improvements to the MVC Validation within MvcContrib, and I decided I'd bring in that codebase to this sample. However, to truly show the full PRG pattern, I needed my form to post and alert me that there are errors on the page rather than relying upon client side validation; so I'm simply using the validator objects & server validation. In the next coming weeks, I'll be making another update to MvcContrib to do model based validation. I'll leave this code for your viewing or other examples on my blog.
And that's the updated sample. You can downloaded the latest bits from here. Please let me know what you think and anything else you would do to change this. As each iteration of the MVC framework is released, the sample gets easier and easier! Hope you enjoy this.
Be the first to rate this post
- Currently 0/5 Stars.
- 1
- 2
- 3
- 4
- 5